fix(FiberHandle): prevent clear() from wiping newer fiber during interrupt wait#6214
Open
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
Open
fix(FiberHandle): prevent clear() from wiping newer fiber during interrupt wait#6214lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
lihan3238 wants to merge 2 commits intoEffect-TS:mainfrom
Conversation
…rrupt wait Save a reference to the target fiber before interrupting, then only clear if the stored fiber still matches the target. This prevents a race where another fiber calls run()/set() during the interrupt wait window and gets its reference unconditionally wiped. Fixes Effect-TS#5906
🦋 Changeset detectedLatest commit: ce27cb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race condition in FiberHandle.clear() where an unconditional state.fiber = undefined could wipe out a newer fiber reference stored by a concurrent run()/set() call during the interrupt wait window.
Save a reference to the target fiber before interrupting, then only clear if state.fiber === target.
Fixes #5906
Test plan